Open
Conversation
this is a noop in OCaml, but fixes the build in OxCaml (which infers stack allocation locality without an explicit annotation in the case of partial application)
raphael-proust
requested changes
Jan 21, 2026
Comment on lines
+1552
to
1553
| let do_recv fd buf pos len fl = if Sys.win32 then Unix.recv fd buf pos len fl else stub_recv fd buf pos len fl in | ||
| wrap_syscall Read ch (fun () -> do_recv ch.fd buf pos len flags) |
Collaborator
There was a problem hiding this comment.
if we're eta-expanding i think we should also inline, very little point in defining the intermediary identifier
wrap_syscall Read ch (fun () -> if Sys.win32 then Unix.recv ch.fd buf pos len flags else stub_recv ch.fd buf pos len flags)
or maybe even better
else if Sys.win32 then
wrap_syscall Read ch (fun () -> Unix.recv ch.fd buf pos len flags)
else
wrap_syscall Read ch (fun () -> stubs_recv ch.fd buf pos len flags)
because it becomes very readable, easy to scan the two lines and spot the difference
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this is a noop in OCaml, but fixes the build in OxCaml (which infers stack allocation locality without an explicit annotation in the case of partial application)